fix: Lowercase all characters on github#53
Merged
kevin-david merged 2 commits intothlorenz:masterfrom Dec 19, 2025
Merged
Conversation
thompson-tomo
changed the title
Contributor
Author
|
@AndrewSouthpaw / @thlorenz i have attempted to work through doctoc issues and this would help close a number of them see thlorenz/doctoc#300 |
AndrewSouthpaw
pushed a commit
to thlorenz/doctoc
that referenced
this pull request
Feb 10, 2026
This ensures that special characters are being correctly handled and producing the expected results. The examples from the below issues have been added to a markdown file and a test added to compared it to the link generated by the github website. Closes: #79 Closes: #92 Closes: #96 Closes: #97 Closes: #122 Closes: #138 Closes: #165 Closes: #172 Closes: #175 Closes: #182 Closes: #193 Closes: #223 Closes: #242 Closes: #260 Blocked by: thlorenz/anchor-markdown-header#52 & thlorenz/anchor-markdown-header#53 Note the update for above also Closes: #167
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that all characters are converted to lowercase for github website.
This has been tested in conjunction with doctoc where it was confirmed that lowercase is the default behaviour of github. Also discovered that tools such as markdownlint, markdown preview in vs code etc also follow this pattern of lowercasing.
I have left the other modes as they were as i have no way to confirm their expected behavior.
Is blocking: thlorenz/doctoc#300