Tl/workflow build snapshots with releases#1
Closed
thlehmann-ionos wants to merge 9 commits intoionos-devfrom
Closed
Tl/workflow build snapshots with releases#1thlehmann-ionos wants to merge 9 commits intoionos-devfrom
thlehmann-ionos wants to merge 9 commits intoionos-devfrom
Conversation
thlehmann-ionos
force-pushed
the
tl/workflow-build-snapshots-with-releases
branch
from
babc2aa to
a3ff87b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // If the default is expected to be a boolean, we need to cast the value | ||
| $value = $this->config->getUserValue($userId, Application::APP_ID, $key, null); | ||
| // If the default value is expected to be a boolean, we need to cast the value | ||
| if ($value === null) { |
Check notice
Code scanning / Psalm
DocblockTypeContradiction
| $value = $this->config->getUserValue($userId, Application::APP_ID, $key, null); | ||
| // If the default value is expected to be a boolean, we need to cast the value | ||
| if ($value === null) { | ||
| $value = $this->appConfig->getAppValueBool($key, $this->getDefaultConfigValue($key)); |
Check failure
Code scanning / Psalm
InvalidScalarArgument
| ?> | ||
|
|
||
| <div class="section" id="mail_general_settings"> | ||
| <?php if ($_['mail_smtpmode'] === 'null') { ?> |
Check notice
Code scanning / Psalm
PossiblyUndefinedArrayOffset
Creates a release from a tag and uses the tag name as artifact name. Changes: * Zip name changed: incorporates the tag name * "write-all" permission requested (needed to create release) * Runs for tags, not branches Conflicts: * Name changed in variable value and Job name 7eb9541
The action previously failed because it required a tag. Reading the source it accepts a "tag_name" parameter, which apparently will create the tag. The "prerelease" option was added because this sounds reasonable for snapshot builds.
Inspired by the fact that the "draft" release (previous change) generated the URL https://github.com/<OWNER AND REPO>/releases/tag/untagged-<HASH> I thought it might not complain about no present tag. This attempts creating a draft release without a tag. Benefit: repo is not "polluted" (although this is not too bad) with snapshot tags. Let's try it ...
The release is currently not even accessible via the API. One has to know the link, which is only printed by the create command. Try to make it searchable
Draft is required, otherwise this error happens: Error:⚠️ GitHub Releases requires a tag This reverts commit 798bb4d.
thlehmann-ionos
force-pushed
the
tl/workflow-build-snapshots-with-releases
branch
3 times, most recently
from
dcf510b to
ede1d94
Compare
thlehmann-ionos
deleted the
tl/workflow-build-snapshots-with-releases
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
softprops/action-gh-releaseaction to create a release with the build .zip as asset and release configured as prereleaseProposal for releases
Tips
API request to fetch newest release:
Proposal for the downstream usage
Remarks
Attempt: keeping tag and build + release of tag separate workflows
It was tried having a workflow tagging upon change to
ionos-devand another workflow building upon "snapshot" tag creation. Yet GitHub would not trigger a workflow upon tag creation that another workflow caused. This is a "security" feature that can be circumvented by configuring personal access tokens (PAT), yet I discarded this for being less secure and requiring regular token renewals.