refactor: extract common loading screen styles into shared CSS file #1255
Conversation
thkruz
commented
Nov 18, 2025
thkruz
commented
- Created loading-screen.common.css with all shared styles
- Updated loading-screen.css to contain only color theme variables
- Updated loading-screen.celestrak.css to contain only color theme variables and unique loading-hint position
- This reduces duplication and makes theme maintenance easier
- Created loading-screen.common.css with all shared styles - Updated loading-screen.css to contain only color theme variables - Updated loading-screen.celestrak.css to contain only color theme variables and unique loading-hint position - This reduces duplication and makes theme maintenance easier
|
|
thkruz
deleted the
claude/update-loading-screen-css-012AF2tqkctttkFAbfa72CCw
branch
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
keeptrack.space/public/css/loading-screen.css
Lines 1 to 5 in 546e75d
Loader stylesheet now drops all layout rules
After this refactor public/css/loading-screen.css is reduced to theme variables only, but src/keeptrack.ts still imports @css/loading-screen.css as the sole loader stylesheet. The new loading-screen.common.css containing the actual #loading-screen, .full-loader, etc. rules is never bundled, so in runtime the loading screen renders unstyled/hidden instead of the intended centered overlay. This impacts any flow that shows the loading overlay.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
