Skip to content

Conversation

@thkruz
Copy link
Owner

@thkruz thkruz commented Jan 4, 2026

This pull request introduces several improvements and integrations related to simulated time control, event management, and test coverage for user account modules. The most significant changes are the addition of simulated time event interfaces and events, tighter integration between the objectives and simulated time, and enhancements to antenna beacon frequency handling. Additionally, a detailed retrospective on testing the user account module has been added.

Simulated Time and Ops Log Integration:

  • Added new simulated time event interfaces (SimulatedTimeTickData) and events (SIMULATED_TIME_TICK, OPS_LOG_ENTRY_ADDED) to the Events enum and EventMap, enabling components to listen for simulated time ticks and ops log changes. [1] [2] [3]
  • Updated ObjectivesManager to pause and resume simulated time (via OpsLogManager) in response to objective state changes, scenario unlocks, completions, and failures, ensuring all timers remain synchronized with simulated time. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Antenna Beacon Frequency Handling:

  • Enhanced AntennaCore so that when a target satellite is set or tracked, the beacon frequency is automatically updated from the satellite's transponder configuration if available. [1] [2]

Test Coverage and Retrospective:

  • Added a comprehensive retrospective document detailing the process, challenges, and results of increasing unit test coverage for the src/user-account module, including coverage statistics and recommendations for future improvements.

Internal Imports and Typings:

  • Added import for OpsLogEntry in events.ts to support new ops log event types.
  • Added import for OpsLogManager in objectives-manager.ts to enable simulated time control.

These changes collectively improve the testability, observability, and synchronization of simulated time with scenario objectives and operational logging.

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
npm/@playwright/test 1.57.0 🟢 6.5
Details
CheckScoreReason
Maintained🟢 1030 commit(s) out of 30 and 6 issue activity out of 30 found in the last 90 days -- score normalized to 10
Code-Review🟢 9GitHub code reviews found for 29 commits out of the last 30 -- score normalized to 9
CII-Best-Practices⚠️ 0no badge detected
Vulnerabilities🟢 10no vulnerabilities detected
Signed-Releases⚠️ -1no releases found
Security-Policy🟢 10security policy file detected
License🟢 10license file detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Packaging⚠️ -1no published package detected
Token-Permissions⚠️ 0non read-only tokens detected in GitHub workflows
Binary-Artifacts🟢 6binaries present in source code
Dependency-Update-Tool🟢 10update tool detected
Fuzzing⚠️ 0project is not fuzzed
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Branch-Protection🟢 3branch protection is not maximal on development and all release branches
npm/fsevents 2.3.2 🟢 3.7
Details
CheckScoreReason
Code-Review🟢 3Found 7/22 approved changesets -- score normalized to 3
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Maintained⚠️ 00 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 0
Packaging⚠️ -1packaging workflow not detected
Binary-Artifacts🟢 10no binaries found in the repo
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Vulnerabilities🟢 100 existing vulnerabilities detected
Security-Policy⚠️ 0security policy file not detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
npm/playwright 1.57.0 🟢 6.5
Details
CheckScoreReason
Maintained🟢 1030 commit(s) out of 30 and 6 issue activity out of 30 found in the last 90 days -- score normalized to 10
Code-Review🟢 9GitHub code reviews found for 29 commits out of the last 30 -- score normalized to 9
CII-Best-Practices⚠️ 0no badge detected
Vulnerabilities🟢 10no vulnerabilities detected
Signed-Releases⚠️ -1no releases found
Security-Policy🟢 10security policy file detected
License🟢 10license file detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Packaging⚠️ -1no published package detected
Token-Permissions⚠️ 0non read-only tokens detected in GitHub workflows
Binary-Artifacts🟢 6binaries present in source code
Dependency-Update-Tool🟢 10update tool detected
Fuzzing⚠️ 0project is not fuzzed
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Branch-Protection🟢 3branch protection is not maximal on development and all release branches
npm/playwright-core 1.57.0 🟢 6.5
Details
CheckScoreReason
Maintained🟢 1030 commit(s) out of 30 and 6 issue activity out of 30 found in the last 90 days -- score normalized to 10
Code-Review🟢 9GitHub code reviews found for 29 commits out of the last 30 -- score normalized to 9
CII-Best-Practices⚠️ 0no badge detected
Vulnerabilities🟢 10no vulnerabilities detected
Signed-Releases⚠️ -1no releases found
Security-Policy🟢 10security policy file detected
License🟢 10license file detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Packaging⚠️ -1no published package detected
Token-Permissions⚠️ 0non read-only tokens detected in GitHub workflows
Binary-Artifacts🟢 6binaries present in source code
Dependency-Update-Tool🟢 10update tool detected
Fuzzing⚠️ 0project is not fuzzed
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Branch-Protection🟢 3branch protection is not maximal on development and all release branches

Scanned Files

  • package-lock.json

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 87.66% 11984 / 13670
🔵 Statements 86.63% 12487 / 14414
🔵 Functions 84.83% 2255 / 2658
🔵 Branches 71.52% 5358 / 7491
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/scenario-manager.ts 100% 100% 100% 100%
src/campaigns/nats/scenario7.ts 100% 50% 100% 100%
src/dev-menu/dev-menu-box.ts 1.06% 0% 0% 1.07%
src/dev-menu/dev-menu-service.ts 65% 40% 66.66% 65%
src/equipment/antenna/antenna-core.ts 75.24% 67.8% 79.51% 75.56%
src/events/events.ts 0% 0% 0% 0%
src/logging/logger.ts 78.26% 70.58% 100% 94.73%
src/objectives/objective-types.ts 0% 0% 0% 0%
src/objectives/objectives-manager.ts 83.98% 77.08% 93.75% 89.03%
src/ops-log/ops-log-manager.ts 100% 96.15% 100% 100%
src/ops-log/ops-log-modal.ts 100% 100% 100% 100%
src/pages/base-page.ts 95.34% 81.03% 100% 96.34%
src/pages/layout/header/header.ts 89.41% 68.75% 86.36% 89.41%
src/pages/mission-control/asset-tree-sidebar.ts 84.71% 62.96% 90% 86.09%
src/pages/mission-control/global-command-bar.ts 97.75% 79.13% 100% 99.41%
src/pages/mission-control/mission-control-page.ts 73.11% 57.14% 66.66% 73.33%
src/pages/mission-control/tabbed-canvas.ts 81.77% 58.13% 94.28% 81.72%
src/pages/mission-control/tabs/acu-control-tab.ts 95.41% 71.68% 88.63% 97.07%
src/pages/mission-control/tabs/omt-adapter.ts 97.82% 60.6% 85.71% 97.61%
src/pages/mission-control/tabs/tx-chain-tab.ts 94.28% 66.66% 100% 94.28%
src/simulation/simulation-manager.ts 79.59% 50% 46.15% 84.78%
src/sync/sync-manager.ts 83.01% 60.29% 85.18% 83.01%
Generated in workflow #186 for commit 111a81a by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants