Open
Conversation
- Add git-worktree-aliases.fish with all functions ported to fish syntax - Detect fish shell in installer, write to ~/.config/fish/config.fish - Use fish-compatible source guard (if test -f ... end) in config.fish - Update uninstaller to remove both .sh and .fish source lines - Document fish install steps in README (curl | bash workaround for psub)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #6
git-worktree-aliases.fish— complete fish-native port of all aliases and functions (wta,wtab,wtp,wtls,wtrm,wtcd,wtinfo,wtdiff,wtrn,wtlock,wtunlock,wtstatus,wtui,grove,zj-kill) using fish syntax (function/end,set -l,if/end,stringbuiltins,psub)install/install.sh— detectsfishshell via$SHELL, writes to~/.config/fish/config.fish, emits a fish-compatible source guard (if test -f ...; source ...; end), and cleans up both.shand.fishlines on uninstallREADME.md— documents fish-specific install commands (curl ... | bashinstead ofbash <(...)since fish doesn't support that process substitution syntax) and manual setup stepsThe problem
Fish shell users couldn't run the one-liner installer because fish doesn't support
bash <(...)process substitution:The fix
Fish users can now install with:
The installer detects fish, writes the correct config, and sources
git-worktree-aliases.fish(valid fish syntax) instead of the bash.shfile.