Multishop #10
Open
Multishop #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdatakick
requested changes
Mar 21, 2025
Contributor
getdatakick
left a comment
getdatakick
left a comment
There was a problem hiding this comment.
Hi,
thank you for this PR, I very much appreciate your work.
Before I merge it, I think this has to be modified a little bit.
It does not really work the same way as the other multistore entities in the system.
As it is, every block can be associated only with single shop, depending on current shop context. Even if I edit the block in 'All Shops' context, it is saved and associated with default shop only. This is not correct in my opinion.
To keep things consistent, we should allow association of the blocks with multiple shops, by displaying the default shop association widget:
Do you think you can amend your PR with this?
Thanks
Petr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module working in multishop mode.