Skip to content

src & srcset - proper escape mode for urls #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cienislaw wants to merge 1 commit into
base: master
Choose a base branch
from
Open

src & srcset - proper escape mode for urls #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions modules/blockbestsellers/blockbestsellers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
class="products-block-image content_img clearfix">
{if !empty($lazy_load)}
<noscript>
<img src="{$link->getImageLink($product.link_rewrite, $product.id_image, 'small', null, ImageManager::retinaSupport())|escape:'html'}"
<img src="{$link->getImageLink($product.link_rewrite, $product.id_image, 'small', null, ImageManager::retinaSupport())|escape:'url'}"
alt="{$product.legend|escape:'html':'UTF-8'}"
width="{getWidthSize|intval type='small'}"
height="{getHeightSize|intval type='small'}"
Expand All @@ -41,13 +41,13 @@
<picture class="img-responsive{if !empty($lazy_load)} tb-lazy-image{/if}">
<!--[if IE 9]><video style="display: none;"><![endif]-->
{if !empty($webp)}
<source {if !empty($lazy_load)}srcset="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII= 1w" data-{/if}srcset="{$link->getImageLink($product.link_rewrite, $product.id_image, 'small', 'webp', ImageManager::retinaSupport())|escape:'html'}"
<source {if !empty($lazy_load)}srcset="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII= 1w" data-{/if}srcset="{$link->getImageLink($product.link_rewrite, $product.id_image, 'small', 'webp', ImageManager::retinaSupport())|escape:'url'}"
sizes="1px"
type="image/webp"
>
{/if}
<!--[if IE 9]></video><![endif]-->
<img {if !empty($lazy_load)}srcset="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII= 1w" data-{/if}srcset="{$link->getImageLink($product.link_rewrite, $product.id_image, 'small', null, ImageManager::retinaSupport())|escape:'html'}"
<img {if !empty($lazy_load)}srcset="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII= 1w" data-{/if}srcset="{$link->getImageLink($product.link_rewrite, $product.id_image, 'small', null, ImageManager::retinaSupport())|escape:'url'}"
{if !empty($lazy_load)}src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII="{/if}
sizes="1px"
alt="{$product.legend|escape:'html':'UTF-8'}"
Expand Down
2 changes: 1 addition & 1 deletion modules/blocknewproducts/blocknewproducts.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<a class="products-block-image" href="{$newproduct.link|escape:'html'}"
title="{$newproduct.legend|escape:html:'UTF-8'}"><img
class="replace-2x img-responsive"
src="{$link->getImageLink($newproduct.link_rewrite, $newproduct.id_image, 'small')|escape:'html'}"
src="{$link->getImageLink($newproduct.link_rewrite, $newproduct.id_image, 'small')|escape:'url'}"
alt="{$newproduct.name|escape:html:'UTF-8'}"
title="{$newproduct.name|escape:html:'UTF-8'}"></a>
<div class="product-content">
Expand Down
6 changes: 3 additions & 3 deletions modules/blockspecials/blockspecials.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
title="{$special.name|escape:'html':'UTF-8'}">
{if !empty($lazy_load)}
<noscript>
<img src="{$link->getImageLink($special.link_rewrite, $special.id_image, 'small', null, ImageManager::retinaSupport())|escape:'html':'UTF-8'}"
<img src="{$link->getImageLink($special.link_rewrite, $special.id_image, 'small', null, ImageManager::retinaSupport())|escape:'url':'UTF-8'}"
alt="{$special.legend|escape:'html':'UTF-8'}"
title="{$special.name|escape:'html':'UTF-8'}"
width="{getWidthSize|intval type='small'}"
Expand All @@ -26,13 +26,13 @@
<picture class="img-responsive{if !empty($lazy_load)} tb-lazy-image{/if}">
<!--[if IE 9]><video style="display: none;"><![endif]-->
{if !empty($webp)}
<source {if !empty($lazy_load)}srcset="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII= 1w" data-{/if}srcset="{$link->getImageLink($special.link_rewrite, $special.id_image, 'small', 'webp', ImageManager::retinaSupport())|escape:'html':'UTF-8'}"
<source {if !empty($lazy_load)}srcset="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII= 1w" data-{/if}srcset="{$link->getImageLink($special.link_rewrite, $special.id_image, 'small', 'webp', ImageManager::retinaSupport())|escape:'url':'UTF-8'}"
title="{$special.name|escape:'html':'UTF-8'}"
type="image/webp"
>
{/if}
<!--[if IE 9]></video><![endif]-->
<img {if !empty($lazy_load)}srcset="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII= 1w" data-{/if}srcset="{$link->getImageLink($special.link_rewrite, $special.id_image, 'small', null, ImageManager::retinaSupport())|escape:'html':'UTF-8'}"
<img {if !empty($lazy_load)}srcset="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII= 1w" data-{/if}srcset="{$link->getImageLink($special.link_rewrite, $special.id_image, 'small', null, ImageManager::retinaSupport())|escape:'url':'UTF-8'}"
{if !empty($lazy_load)}src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII="{/if}
alt="{$special.legend|escape:'html':'UTF-8'}"
title="{$special.name|escape:'html':'UTF-8'}"
Expand Down
12 changes: 6 additions & 6 deletions modules/blockwishlist/views/templates/front/managewishlist.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
>
{if !empty($lazy_load)}
<noscript>
<img src="{$link->getImageLink($product.link_rewrite, $product.cover, 'home', null, ImageManager::retinaSupport())|escape:'html':'UTF-8'}"
<img src="{$link->getImageLink($product.link_rewrite, $product.cover, 'home', null, ImageManager::retinaSupport())|escape:'url':'UTF-8'}"
alt="{$product.name|escape:'html':'UTF-8'}"
width="{getWidthSize|intval type='home'}"
height="{getHeightSize|intval type='home'}"
Expand All @@ -60,12 +60,12 @@
<picture class="replace-2x img-responsive{if !empty($lazy_load)} tb-lazy-image{/if}">
<!--[if IE 9]><video style="display: none;"><![endif]-->
{if !empty($webp)}
<source {if !empty($lazy_load)}srcset="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII= 1w" data-{/if}srcset="{$link->getImageLink($product.link_rewrite, $product.cover, 'home', 'webp', ImageManager::retinaSupport())|escape:'html':'UTF-8'}"
<source {if !empty($lazy_load)}srcset="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII= 1w" data-{/if}srcset="{$link->getImageLink($product.link_rewrite, $product.cover, 'home', 'webp', ImageManager::retinaSupport())|escape:'url':'UTF-8'}"
type="image/webp"
>
{/if}
<!--[if IE 9]></video><![endif]-->
<img {if !empty($lazy_load)}srcset="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII= 1w" data-{/if}srcset="{$link->getImageLink($product.link_rewrite, $product.cover, 'home', null, ImageManager::retinaSupport())|escape:'html':'UTF-8'}"
<img {if !empty($lazy_load)}srcset="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII= 1w" data-{/if}srcset="{$link->getImageLink($product.link_rewrite, $product.cover, 'home', null, ImageManager::retinaSupport())|escape:'url':'UTF-8'}"
{if !empty($lazy_load)}src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII="{/if}
alt="{$product.name|escape:'html':'UTF-8'}"
width="{getWidthSize|intval type='home'}"
Expand Down Expand Up @@ -200,7 +200,7 @@
<span style="float:left;">
{if !empty($lazy_load)}
<noscript>
<img src="{$link->getImageLink($product.link_rewrite, $product.cover, 'small', null, ImageManager::retinaSupport())|escape:'html':'UTF-8'}"
<img src="{$link->getImageLink($product.link_rewrite, $product.cover, 'small', null, ImageManager::retinaSupport())|escape:'url':'UTF-8'}"
alt="{$product.name|escape:'html':'UTF-8'}"
width="{getWidthSize|intval type='small'}"
height="{getHeightSize|intval type='small'}"
Expand All @@ -210,13 +210,13 @@
<picture {if !empty($lazy_load)}class="tb-lazy-image"{/if}>
<!--[if IE 9]><video style="display: none;"><![endif]-->
{if !empty($webp)}
<source {if !empty($lazy_load)}srcset="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII= 1w" data-{/if}srcset="{$link->getImageLink($product.link_rewrite, $product.cover, 'small', 'webp', ImageManager::retinaSupport())|escape:'html':'UTF-8'}"
<source {if !empty($lazy_load)}srcset="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII= 1w" data-{/if}srcset="{$link->getImageLink($product.link_rewrite, $product.cover, 'small', 'webp', ImageManager::retinaSupport())|escape:'url':'UTF-8'}"
alt="{$product.name|escape:'html':'UTF-8'}"
type="image/webp"
>
{/if}
<!--[if IE 9]></video><![endif]-->
<img {if !empty($lazy_load)}srcset="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII= 1w" data-{/if}srcset="{$link->getImageLink($product.link_rewrite, $product.cover, 'small', null, ImageManager::retinaSupport())|escape:'html':'UTF-8'}"
<img {if !empty($lazy_load)}srcset="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII= 1w" data-{/if}srcset="{$link->getImageLink($product.link_rewrite, $product.cover, 'small', null, ImageManager::retinaSupport())|escape:'url':'UTF-8'}"
{if !empty($lazy_load)}src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII="{/if}
alt="{$product.name|escape:'html':'UTF-8'}"
width="{getWidthSize|intval type='small'}"
Expand Down
6 changes: 3 additions & 3 deletions modules/blockwishlist/views/templates/front/view.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
>
{if !empty($lazy_load)}
<noscript>
<img src="{$link->getImageLink($product.link_rewrite, $product.cover, 'home', null, ImageManager::retinaSupport())|escape:'html':'UTF-8'}"
<img src="{$link->getImageLink($product.link_rewrite, $product.cover, 'home', null, ImageManager::retinaSupport())|escape:'url':'UTF-8'}"
alt="{$product.name|escape:'html':'UTF-8'}"
width="{getWidthSize|intval type='home'}"
height="{getHeightSize|intval type='home'}"
Expand All @@ -53,12 +53,12 @@
<picture class="img-responsive{if !empty($lazy_load)} tb-lazy-image{/if}">
<!--[if IE 9]><video style="display: none;"><![endif]-->
{if !empty($webp)}
<source {if !empty($lazy_load)}srcset="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII= 1w" data-{/if}srcset="{$link->getImageLink($product.link_rewrite, $product.cover, 'home', 'webp', ImageManager::retinaSupport())|escape:'html':'UTF-8'}"
<source {if !empty($lazy_load)}srcset="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII= 1w" data-{/if}srcset="{$link->getImageLink($product.link_rewrite, $product.cover, 'home', 'webp', ImageManager::retinaSupport())|escape:'url':'UTF-8'}"
type="image/webp"
>
{/if}
<!--[if IE 9]></video><![endif]-->
<img {if !empty($lazy_load)}srcset="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII= 1w" data-{/if}srcset="{$link->getImageLink($product.link_rewrite, $product.cover, 'home', null, ImageManager::retinaSupport())|escape:'html':'UTF-8'}"
<img {if !empty($lazy_load)}srcset="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII= 1w" data-{/if}srcset="{$link->getImageLink($product.link_rewrite, $product.cover, 'home', null, ImageManager::retinaSupport())|escape:'url':'UTF-8'}"
{if !empty($lazy_load)}src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII="{/if}
alt="{$product.name|escape:'html':'UTF-8'}"
width="{getWidthSize|intval type='home'}"
Expand Down
6 changes: 3 additions & 3 deletions modules/favoriteproducts/views/templates/front/favoriteproducts-account.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,19 @@
>
{if !empty($lazy_load)}
<noscript>
<img src="{$link->getImageLink($favoriteProduct.link_rewrite, $favoriteProduct.image, 'medium')|escape:'html':'UTF-8'}"
<img src="{$link->getImageLink($favoriteProduct.link_rewrite, $favoriteProduct.image, 'medium')|escape:'url':'UTF-8'}"
alt="{favoriteProduct.name|escape:'htmlall':'UTF-8'}"
width="{getWidthSize|intval type='medium'}"
height="{getHeightSize|intval type='medium'}"
>
</noscript>
{/if}
<picture {if !empty($lazy_load)}class="tb-lazy-image"{/if}>
<source {if !empty($lazy_load)}srcset="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII= 1w" data-{/if}srcset="{$link->getImageLink($favoriteProduct.link_rewrite, $favoriteProduct.image, 'medium')|escape:'html':'UTF-8'}"
<source {if !empty($lazy_load)}srcset="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII= 1w" data-{/if}srcset="{$link->getImageLink($favoriteProduct.link_rewrite, $favoriteProduct.image, 'medium')|escape:'url':'UTF-8'}"
alt="{favoriteProduct.name|escape:'htmlall':'UTF-8'}"
type="image/webp"
>
<img {if !empty($lazy_load)}srcset="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII= 1w" data-{/if}srcset="{$link->getImageLink($favoriteProduct.link_rewrite, $favoriteProduct.image, 'medium')|escape:'html':'UTF-8'}"
<img {if !empty($lazy_load)}srcset="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII= 1w" data-{/if}srcset="{$link->getImageLink($favoriteProduct.link_rewrite, $favoriteProduct.image, 'medium')|escape:'url':'UTF-8'}"
{if !empty($lazy_load)}src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII="{/if}
alt="{favoriteProduct.name|escape:'htmlall':'UTF-8'}"
width="{getWidthSize|intval type='medium'}"
Expand Down
2 changes: 1 addition & 1 deletion modules/mailalerts/views/templates/front/mailalerts-account.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
{foreach from=$mailAlerts item=mailAlert name=myLoop}
<li class="clearfix">
<a class="products-block-image" href="{$link->getProductLink($mailAlert.id_product, null, null, null, null, $mailAlert.id_shop)}" title="{$mailAlert.name|escape:'html':'UTF-8'}">
<img src="{$link->getImageLink($mailAlert.link_rewrite, $mailAlert.cover, 'small')|escape:'html'}" alt="">
<img src="{$link->getImageLink($mailAlert.link_rewrite, $mailAlert.cover, 'small')|escape:'url'}" alt="">
</a>
<div class="product-content">
<span class="remove">
Expand Down
Loading