-
Notifications
You must be signed in to change notification settings - Fork 25
Font awesome 6.7.2 #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cienislaw
wants to merge
15
commits into
thirtybees:master
Choose a base branch
from
cienislaw:font_awesome_6.7.2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cienislaw
commented
Apr 13, 2025
- Removed Font Awesome v4;
- Changed from Font Awesome v3 class pattern 'icon icon-' to v6 'fas fa-', 'far fa-' and 'fab fa-';
- All icon class names translated to v6 without using aliases;
- Added 'FontAwesome' v4 compatibility font-face for 3rd party modules which use icon codes, so more of them should work without any fixes;
- No css compilation;
Added missing 'icon' class to icons using font awesome for easier migration to v6
Removed extra css style for account entries icons and used existing icon-fw
removed extra space in class
Added span parent and moved colour class there.
Removed Font Awesome v4 webfonts and sass files
Added Font Awesome v6 web font and sass files
Setting up Sass for new fonts
Defined Sass files source, which excludes vendor files from compilation.
All template files were updated to use Font Awesome 6.7.2.
All JS files were updated to use Font Awesome 6.7.2.
Moved from Star to Heart to be consistent with icon in My Account entry and Block Wishlist. Module installs but My Account is not working. https://github.com/PrestaShop/favoriteproducts
All Sass files were updated to use Font Awesome 6.7.2.
This commit should increase compatibility with 3rd party modules which assume that FontAwesome font-family is there and use icon codes instead of old classes pattern 'icon icon-*'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.