Skip to content

Conversation

@cienislaw
Copy link
Contributor

  • Removed Font Awesome v4;
  • Changed from Font Awesome v3 class pattern 'icon icon-' to v6 'fas fa-', 'far fa-' and 'fab fa-';
  • All icon class names translated to v6 without using aliases;
  • Added 'FontAwesome' v4 compatibility font-face for 3rd party modules which use icon codes, so more of them should work without any fixes;
  • No css compilation;

Added missing 'icon' class to icons using font awesome for easier migration to v6
Removed extra css style for account entries icons and used existing icon-fw
removed extra space in class
Added span parent and moved colour class there.
Removed Font Awesome v4 webfonts and sass files
Added Font Awesome v6 web font and sass files
Setting up Sass for new fonts
Defined Sass files source, which excludes vendor files from compilation.
All template files were updated to use Font Awesome 6.7.2.
All JS files were updated to use Font Awesome 6.7.2.
Moved from Star to Heart to be consistent with icon in My Account entry and Block Wishlist. Module installs but My Account is not working.

https://github.com/PrestaShop/favoriteproducts
All Sass files were updated to use Font Awesome 6.7.2.
This commit should increase compatibility with 3rd party modules which assume that FontAwesome font-family is there and use icon codes instead of old classes pattern 'icon icon-*'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant