fix(exchange): allow direct exchange rate entry relative to the stronger currency#8631
Open
Bharadwaj-2024 wants to merge 1 commit intothird-culture-software:masterfrom
Conversation
…rrency When the enterprise currency is weak, users can now enter exchange rates directly relative to the strong currency (e.g. 1 USD = 920 CDF) instead of being forced to enter fractional values (e.g. 0.00108). - Detect weak currency scenario (rate < 1) in exchange modal - Swap input labels to show '1 Foreign = ? Enterprise' for weak currencies - Convert user input back to internal format (1/rate) on submit - Per-currency display logic in bhExchangeRate header component - Human-readable rate display in exchange rate list (bhExchange) - Updated i18n hints (en/fr) - No changes to database schema, SQL procedures, or conversion logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rrency
When the enterprise currency is weak, users can now enter exchange rates directly relative to the strong currency (e.g. 1 USD = 920 CDF) instead of being forced to enter fractional values (e.g. 0.00108).