Skip to content

Added callback for postprocessing the GUIDs list#4

Open
ZimM-LostPolygon wants to merge 3 commits intothinksquirrel:masterfrom
LostPolygon:master
Open

Added callback for postprocessing the GUIDs list#4
ZimM-LostPolygon wants to merge 3 commits intothinksquirrel:masterfrom
LostPolygon:master

Conversation

@ZimM-LostPolygon
Copy link

No description provided.

Copy link
Contributor

@lilyvelour lilyvelour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just one minor change needed for backwards compatibility.

If I may ask, what use case did you have in mind for this callback?

@ZimM-LostPolygon
Copy link
Author

ZimM-LostPolygon commented Jul 22, 2018

My use case:
The SDK project has some folders like:

Assets/MySdk/
Assets/MySdkTests/
Assets/MySdkBuildScripts/
Assets/MySdkThirdPartyIntegrations/

This is convenient for working with the project, but with the normal Asset Store upload process, it would mean that all these folders will be uploaded, whereas I only want to upload the contents of Assets/MySDK/ folder. This callback allows me to filter out files that I don't want to be included in the Asset Store package.

Actually, I've been using it like that for a few years, and just realized I hadn't done the PR :)

Serhii Yolkin added 2 commits December 2, 2018 00:50
# Conflicts:
#	AssetStoreBatchMode/AssetStoreBatchMode.cs
@ZimM-LostPolygon
Copy link
Author

@lmontoute Updated my branch. Can this be merged now, perhaps? Calling from command line is not an issue, guidListPostprocessCallback will just be null.

Copy link
Contributor

@lilyvelour lilyvelour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code here has my approval but one minor change is needed. Some lines seem to have been converted to tabs (and some changed as well), which will break our internal linter — can we revert the unnecessary format changes and ensure the added lines are formatted correctly?

}

var assets = mainAssets;
var opt = new OptionSet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any actual changes in this block?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants