Skip to content

Comments

[IMP] edi_storage_oca: Allow files with duplicate names to create Edi Exchange Record#36

Open
thienvh332 wants to merge 1 commit into12.0-bprt-edi_storage_ocafrom
12.0-imp-edi_storage_oca
Open

[IMP] edi_storage_oca: Allow files with duplicate names to create Edi Exchange Record#36
thienvh332 wants to merge 1 commit into12.0-bprt-edi_storage_ocafrom
12.0-imp-edi_storage_oca

Conversation

@thienvh332
Copy link
Owner

No description provided.

@thienvh332 thienvh332 force-pushed the 12.0-imp-edi_storage_oca branch from dfd6171 to 8c5eb48 Compare February 6, 2025 09:37
<field name="input_dir_remove" />
<field
name="input_allow_duplicate_filename"
attrs="{'invisible': [('input_dir_remove', '=', False)]}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
attrs="{'invisible': [('input_dir_remove', '=', False)]}"

"Output error directory", help="Path to folder for error operations"
)
input_allow_duplicate_filename = fields.Boolean(
help="Allow files with duplicate names to create Edi Exchange Record")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
help="Allow files with duplicate names to create Edi Exchange Record")
help="For this backend, filenames are not unique, e.g. output.edi")

@thienvh332 thienvh332 force-pushed the 12.0-imp-edi_storage_oca branch from 8c5eb48 to 52bf140 Compare February 10, 2025 10:42
</field>
</record>
</odoo>
</odoo> No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline

@thienvh332 thienvh332 force-pushed the 12.0-imp-edi_storage_oca branch from 52bf140 to 8f7b612 Compare February 10, 2025 11:05
@thienvh332 thienvh332 force-pushed the 12.0-imp-edi_storage_oca branch from 8f7b612 to 16257eb Compare February 11, 2025 03:37
@nilshamerlinck
Copy link

didn't make it to the oca side?

@thienvh332
Copy link
Owner Author

didn't make it to the oca side?

Hi sir,
This PR is based on the 12.0-bprt-edi_storage_oca branch. But its PR on the OCA side is not being cared about. So I am not creating a PR for this at the moment.

Should I create a new PR for this? (Although they don't seem to care)

@nilshamerlinck
Copy link

yes please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants