Merged
Conversation
thibautbenjamin
force-pushed
the
features/improvements
branch
2 times, most recently
from
c451716 to
affe563
Compare
thibautbenjamin
force-pushed
the
features/improvements
branch
from
affe563 to
6ef5384
Compare
thibautbenjamin
force-pushed
the
features/improvements
branch
from
6ef5384 to
e7c6fe2
Compare
Owner
Author
|
@regular-citizen These are various changes that are kind of required for Eckmann-Hilton, could you please review them? |
regular-citizen
approved these changes
Sep 10, 2025
Collaborator
regular-citizen
left a comment
regular-citizen
left a comment
There was a problem hiding this comment.
Left minor comments, some refactoring needed
Owner
Author
|
I resolved all the comments that called for an answer. The only 2 comments left concern things that are stylistic and explanation of the code that is already there, so I am merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR contains various improvements and facilities to easily construct complex terms. Our development of Eckmann-Hilton cells (#90) relies on them, I extracted it on its own, as it is a substantial development that is not really part of eh in itself