Conversation
|
@thgh if you feel comfortable with giving me merge rights, I can move this along without a review. I'll be putting out quite a couple of PRs to keep things reviewable, so it could be favorable to do so. If you prefer to review them individually before merging, that is also fine by me. Let me know what works for you. |
|
I would recommend against this. I don't agree with your reasons. If you can automate testing by switching to NPM, that's a good reason though! As a collaborator, I think you have merge rights. The main branch requires a review though. Ideally, you create 1 PR with all changes required to fix the types issue. If a PR doesn't fix something, I'm hesitant to merge. Don't fix what's not broken. |
|
My main reason for this is that when setting up automation I will not have to set up Yarn. For example,
I'll do this separately. I like to make breaking changes explicit commits, so the changelog can be easily compiled from the commit history. |
|
setup-node installs yarn by default, will close this as you can do this in the @rollup/plugins repo |
Switches the package manager from Yarn to NPM. This replaces the old Yarn lockfile with an NPM version. There are a couple of reasons for doing this: