Open
Conversation
thgh
requested changes
Feb 3, 2021
src/index.js
Outdated
| return { | ||
| name: 'css', | ||
| buildStart() { | ||
| hasChanged = false |
Owner
There was a problem hiding this comment.
If a build takes 10s and you save an irrelevant file after 5s, hasChanged will be false at the moment that generateBundle takes place. I think this might introduce a race-condition. Does this change address a bug in the current version?
Maybe we should remove all change detection to make things simpler?
Collaborator
There was a problem hiding this comment.
That change is from my pull request. You raise a good point, I’ll think about what to do about this and update my PR
Owner
|
Can you further discuss this with @jerekshoe and merge it into the v4 branch? |
Co-authored-by: Thomas Ghysels <info@thomasg.be>
thgh
previously approved these changes
Feb 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on #29
parses
@import './test.css'lines in CSS files and adds them as imports within rollup,e.g.,
will create the following intermediate JS module
Thus, triggers import the imported files during bundling.