Fixes for KSP 1.5.0 by Flupster · Pull Request #29 · thewebbooth/KSP-X-Science

Flupster · 2018-10-16T17:10:52Z

No description provided.

MateoCB · 2018-10-17T01:58:56Z

This is working nicely, thanks @Flupster

CptBoBy · 2018-10-18T16:37:39Z

compiled the mod with the modified files ,still doesn't work.

Flupster · 2018-10-18T17:01:35Z

I'll upload the compiled files later tonight and link them here, compiled fine for me and worked

DonCorleone-NL · 2018-10-18T17:19:20Z

That would be awesome Flupster, thx alot mate!

new01DAY · 2018-10-18T17:43:45Z

I'm not sure, but I think it doesn't work for some because of the changes to [x] Science!.csproj <HintPath>E:\SteamLibrary\steamapps\common\Kerbal Space Program\KSP_x64_Data\Managed\UnityEngine.dll</HintPath> from <HintPath>..\..\..\..\Games\KSP\KSP_Real\KSP_x64_Data\Managed\UnityEngine.dll</HintPath>.

Flupster · 2018-10-18T17:45:55Z

You need to add the references to the DLLs,mine was in another location,however I reverted it back in the second commit

new01DAY · 2018-10-18T17:48:53Z

Yeah, sorry. I just realized why/what it was. I actually don't know much about compiling and I'm trying to figure it out.

CptBoBy · 2018-10-18T18:16:44Z

compiled without problems having set the proper references , but game still says incompatible and the x science window appears completely empty.

Flupster · 2018-10-18T19:47:16Z

zip of the compiled mod can be found in my fork releases over at https://github.com/Flupster/KSP-X-Science/releases/

Flupster · 2018-10-18T20:02:43Z

compiled without problems having set the proper references , but game still says incompatible and the x science window appears completely empty.

Just did a full reinstall of KSP dropped in the mod from my forks release page and works, i'm not sure why yours isn't working but you could try mine?

https://i.imgur.com/qSoSuF9.jpg

CptBoBy · 2018-10-18T20:47:59Z

compiled without problems having set the proper references , but game still says incompatible and the x science window appears completely empty.

Just did a full reinstall of KSP dropped in the mod from my forks release page and works, i'm not sure why yours isn't working but you could try mine?

https://i.imgur.com/qSoSuF9.jpg

tried with my old install , not even the empty science window appeared. completely reinstalled ksp ,and same thing ,at startup game says mod compatible only with 1.4.5 ,and game pretends mod is not even installed

Flupster · 2018-10-19T16:57:33Z

Thanks. But your 5.17.2 release zip that includes this change is broken - only 22 bytes.

My bad forgot to actually include in the mod within the zip, should be fixed now!

Oeddish · 2018-10-20T21:19:31Z

FWIW I came here to submit a PR with more or less your exact changes, which work for me (with minor differences I'll comment on in the diff). Would suggest also updating CHANGES.md to keep the project consistent.

X-Science/GameData/[x] Science!/[x] Science!.version

Oeddish · 2018-10-20T21:22:44Z

X-Science/ScienceChecklistAddon.cs

                {
                    // Set the music volume to what it was before
-                    MusicLogic.SetVolume(oldVolume);
+                    MusicLogic.SetVolume(oldVolume, oldVolume);


Not sure if it matters, but i tested this with 0f rather than oldVolume for the parameter. Seemed to work as expected.

I have to be honest, I'm not entirely sure what the second parameter of SetVolume is, it just required a float so I used the first parameter as the second, If you know what the second parameter is let me know and if 0f is the better option for the second parameter

…ersions

Tekaoh2 · 2018-10-22T14:23:59Z

This works on my machine. +1 vote for merge so it can go on CKAN

Flupster · 2018-12-22T11:52:21Z

Updated for v1.6.0 of KSP, no actual changes were made just the version numbers, tested a little all seems to be working.

SilkDev · 2019-01-17T14:39:56Z

Hey @Flupster, it seems there's no maintainers left here, maybe you could push it to CKAN as a new package ?

Or maybe a little ping to @thewebbooth could work ?

This was broken, requests coming from `%255Bx%255D%2520Science%2521/%255Bx%255D%2520Science%2521.version`

…mateGeneric

…d vessels, is disabled by default

Performance improvements & DMagic API fixes

Perhaps these science combinations were not possible at one time, but they are definitely possible now. I've achieved them using the Field Science contract pack to help me with the waypoints. But the contract pack is not required if you know where they are.

Comment out an outdated assumption

… science value in brackets. Improved performance.

In KSP 1.8.0, some parts throw a NullReferenceException when doing this. Interestingly, the parts that throw this are the kerbalEVA* parts from the DLCs when you don't have the DLCs.

Ignore null exception when gathering experiments

Science threshold feature for Here and Now window.

Flupster added 2 commits October 16, 2018 17:52

Fixes for KSP 1.5.0

53e17ba

Revert csproj

fd834c6

corey-hammerton mentioned this pull request Oct 16, 2018

not working with ksp 1.5.0 #28

Open

KSP 1.5.1 fix

a8a69c5

Oeddish reviewed Oct 20, 2018

View reviewed changes

X-Science/GameData/[x] Science!/[x] Science!.version Outdated Show resolved Hide resolved

Oeddish reviewed Oct 20, 2018

View reviewed changes

Minor version bump to keep with historical recompiling of newer KSP v…

38f499d

…ersions

Flupster added 2 commits October 22, 2018 19:43

AssemblyInfo update forgot to changefor v5.18

afc633e

Change versioning for KSP 1.6.0

57464d3

SilkDev mentioned this pull request Feb 5, 2019

Update for 1.6.x #30

Open

Flupster added 4 commits February 23, 2019 22:27

Changes for v1.6.1 of KSP also update .version for CKAN

6de89b4

Update [x] Science!.version

ac3421e

This was broken, requests coming from `%255Bx%255D%2520Science%2521/%255Bx%255D%2520Science%2521.version`

changes for KSP 1.7.0

4e88cce

Forgot to change download URL

c13218b

siimav and others added 26 commits May 12, 2019 00:04

Fixed performance issues with RP-1

15c73af

DMagic API changes

400611a

Add support for the new totalScienceLevel field in DMModuleScienceAni…

e728b98

…mateGeneric

Fixed return statements in IsAmountLimitedByDMagic()

31114bc

Fixed RunExperiment() bypassing DMagic module checks

02d33c5

Fixed CanRunExperiment() for DMModuleScienceAnimateGeneric

a0b52c0

Added a config setting for checking for experiment results on unloade…

116b8a7

…d vessels, is disabled by default

Updated version file to support KSP versions starting from 1.5

6e42958

Merge pull request #1 from siimav/flupster

7e9be3e

Performance improvements & DMagic API fixes

v5.22 Release

c635d2d

Update CHANGES.md

ff4dc36

Update CHANGES.md

6905577

Update [x] Science!.version

7cfb494

Merge pull request #2 from Tekaoh/patch-1

7d98a99

Comment out an outdated assumption

Here and Now: Created science threshold slider. Added next experiment…

d5192c9

… science value in brackets. Improved performance.

Here and Now: Fixed science threshold save/load functionality.

eaa142f

Removed fire events debug logging.

255fa23

Fixed performance issues. Implemented acceleration slider.

5eea1bc

Ignore null exception when gathering experiments

b3988f2

In KSP 1.8.0, some parts throw a NullReferenceException when doing this. Interestingly, the parts that throw this are the kerbalEVA* parts from the DLCs when you don't have the DLCs.

Merge pull request #6 from trosine/ksp_1.8.0

6ddef7e

Ignore null exception when gathering experiments

Changes for 1.8

dbbec44

v5.24 recompile for 1.9 ksp

16279c8

My bad, typo in min version

3d2f91b

Merge pull request #5 from IDizor/master

1c12ab6

Science threshold feature for Here and Now window.

Version bump

3ba43b8

Conversation

Flupster commented Oct 16, 2018

Uh oh!

MateoCB commented Oct 17, 2018

Uh oh!

CptBoBy commented Oct 18, 2018

Uh oh!

Flupster commented Oct 18, 2018

Uh oh!

DonCorleone-NL commented Oct 18, 2018

Uh oh!

new01DAY commented Oct 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Flupster commented Oct 18, 2018

Uh oh!

new01DAY commented Oct 18, 2018

Uh oh!

CptBoBy commented Oct 18, 2018

Uh oh!

Flupster commented Oct 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Flupster commented Oct 18, 2018

Uh oh!

CptBoBy commented Oct 18, 2018

Uh oh!

Flupster commented Oct 19, 2018

Uh oh!

Oeddish commented Oct 20, 2018

Uh oh!

Uh oh!

Oeddish Oct 20, 2018

Choose a reason for hiding this comment

Uh oh!

Flupster Oct 20, 2018

Choose a reason for hiding this comment

Uh oh!

Tekaoh2 commented Oct 22, 2018

Uh oh!

Flupster commented Dec 22, 2018

Uh oh!

SilkDev commented Jan 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

new01DAY commented Oct 18, 2018 •

edited

Loading

Flupster commented Oct 18, 2018 •

edited

Loading