Skip to content

Conversation

@lukpueh
Copy link
Member

@lukpueh lukpueh commented Oct 4, 2019

Fixes issue #:
Closes #927

Description of the changes being introduced by the pull request:

  • remove duplicate ROLENAME_SCHEMA and ROLEDICT_SCHEMA
  • remove outdated and duplicate ROLE_SCHEMA

Note that this is a quick fix that may be overridden with refactoring work in #660/#846.

Please verify and check that the pull request fulfills the following
requirements
:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

- remove duplicate ROLENAME_SCHEMA and ROLEDICT_SCHEMA
- remove outdated and duplicate ROLE_SCHEMA

Note that this is a quick fix that may be overridden with
refactoring work in theupdateframework#660/theupdateframework#846.

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
Copy link
Contributor

@trishankatdatadog trishankatdatadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@trishankatdatadog trishankatdatadog added this to the 0.12.0 milestone Oct 4, 2019
@lukpueh lukpueh merged commit be601bb into theupdateframework:develop Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate definitions of schemas

3 participants