added font support. original author @jasonwebster #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Jason. Thanks for the PR! Do you feel like it's ready to go, or are you just looking for some feedback on it? |
Author
|
Good question. I can't say that I'm fully comfortable with what I wrote, since I don't fully understand the innards of forge. It works for me locally, but I didn't run it against setting up a new project, only my existing one. If you have feedback I would love to hear it. Thanks! |
|
Thanks Jason. Unfortunately, I'm not the guy to review this code, and we're a little strapped for resources at the moment, so this will probably have to sit around for awhile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I may have missed a few things, such as the generator. Thoughts?