Merged
Conversation
Add '|| true' to grep command to prevent exit code 1 from causing workflow failure when no version tags are found on the commit. This fixes the docs workflow failure introduced in #32.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #32 introduced a bug where the docs workflow fails when checking for version tags on commits without tags. The grep command returns exit code 1 when no match is found, causing the workflow to fail due to bash's
-eflag.Fix
Add
|| trueto the grep command to ensure it always returns exit code 0, even when no tags are found.Changes
TAGS=$(git tag --points-at HEAD | grep '^v' || true)This allows the workflow to continue and correctly set
is_release=falsewhen no version tags are present.Test
This will be tested when the PR is merged and the workflow runs on main.