Issue #11 Set ClientIp via the parameters form.#15
Issue #11 Set ClientIp via the parameters form.#15judgej wants to merge 1 commit intothephpleague:masterfrom
Conversation
Still not ideal - seems too much repitition in code. Also the clientIp is not retreived from the session, but many other fields (e.g. return URLs) are also not retrieved from the session when re-presenting the request form, so it is consistent at least, but could do with some improvements.
|
The idea of this is that for the demo purposes, the client IP address is not blindly passed to the gateway driver. Instead it is presented to the user first, who can modify it or blank it out if necessary, then submit the transaction with the modified IP. |
|
I cannot see the fork this PR is based on listed anywhere in the "forks" window, so I am not entirely confident that it contains the right code. I think sometimes, when in branch hell, the only option is to burn it all down and start again. I'll do that tomorrow. |
|
Burning it down and starting again gets my vote. It kinda looks OK at first glance, though. |
|
This is a bit old! I blink once and I'm away from the example application for three years. Still relevant, though I need to look again to make sure the solution is the right approach. |
3 participants
Still not ideal - seems too much repitition in code. Also the clientIp is
not retreived from the session, but many other fields (e.g. return URLs) are also
not retrieved from the session when re-presenting the request form, so it is
consistent at least, but could do with some improvements.