ci: Introduce a meta job for the tests#166
Open
theofidry wants to merge 6 commits intothephpleague:masterfrom
Open
ci: Introduce a meta job for the tests#166theofidry wants to merge 6 commits intothephpleague:masterfrom
theofidry wants to merge 6 commits intothephpleague:masterfrom
Conversation
When adding GitHub protection rules for a job, one needs to select the jobs based on the name, for example here "coding standards / coding standards". However, for jobs that are issued from a matrix, like here the unit test, one needs to add "unit tests / PHP 8.1 - Symfony 5.4.* - Composer --prefer-stable", "unit tests / PHP 8.2 - Symfony 5.4.* - Composer --prefer-stable" and co. manually. This is both tedious to add and to keep up to date as any change in the matrix result in this rule to be outdated. This PR introduces a very simple solution: have a meta job that passes if and only if all of the unit tests passes. This way we can have a rule for this job instead, which has a fixed label.
…ecration chore: Fix Bamarni plugin deprecations
Contributor
Author
|
@chalasr ready (beware it does require you to update the repository settings to add the "tests status" job as a required job for the |
Member
|
Sadly I don't have enough permissions to access this repository's settings, so merging this would require some real-time round trips with @thephpleague/oauth2-server-bundle maintainers that I can't afford at the moment. |
Member
|
@chalasr can you check if it works now? |
Member
|
@frankdejonge all good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding GitHub protection rules for a job, one needs to select the jobs based on the name, for example here "coding standards / coding standards".
However, for jobs that are issued from a matrix, like here the unit test, one needs to add
unit tests / PHP 8.1 - Symfony 5.4.* - Composer --prefer-stable,unit tests / PHP 8.2 - Symfony 5.4.* - Composer --prefer-stableand co. manually. This is both tedious to add and to keep up to date as any change in the matrix result in this rule to be outdated.This PR introduces a very simple solution: have a meta job that passes if and only if all of the unit tests passes. This way we can have a rule for this job instead, which has a fixed label.