Skip to content

Conversation

@piotr-cz
Copy link
Contributor

@piotr-cz piotr-cz commented Dec 3, 2025

@ADmad
Copy link
Collaborator

ADmad commented Dec 3, 2025

I don't think BMP has any place on the web :)

Merging this can potentially open a DDOS vector for existing apps given that BMPs can take up a huge amount of memory.

@piotr-cz
Copy link
Contributor Author

piotr-cz commented Dec 4, 2025

I understand and I can't say that I wasn't expecting this.

Just please don't mark League\Glide\Api\Api and League\Glide\Api\Encoder classes as final, because extending these is the only way to add support for formats that are available in intervention/image.

For example psalm suggests adding @Api docblock in such case

@piotr-cz piotr-cz closed this Dec 4, 2025
@piotr-cz piotr-cz mentioned this pull request Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BMP file support

2 participants