Skip to content

Conversation

@LennardF1989
Copy link
Member

Applied some changes from #388:

  • Switched to SDK-style, but still builds as net46.
  • Separated patcher logic from UI

This allows me to rebase my dev/patcher-core branch later and make the actual changes compared to the net46 version a lot easier to review/check.

Draft PR so I can test CI/CD while I'm at it.

This PR will get the "Re-enable Dynamic Resources"-patch before switching to a normal PR for consideration.

@LennardF1989
Copy link
Member Author

Last commit adds patch to re-enable Dynamic Resources starting 3.210 (technically untested, since I'm already on a slightly higher version). See this for easy comparison.

The patch is treated as optional, meaning it does not fail a offset scan if it's not found. I kept the newly added code in line with however the original is structured, since my intention is not to do a refactor.

You can download the build from the CI here.

Acceptance criteria:

  • Should be more or less the same size as the original PeacockPatcher.exe that's in the root of the project
  • Should work with existing configuration (peacock_patcher.conf)
  • Should restore loading Dynamic Resources, mostly visible by going to the main menu in-game. You should not see [UI_PEACOCK...] anymore.

@LennardF1989 LennardF1989 marked this pull request as ready for review May 8, 2025 23:57
@LennardF1989 LennardF1989 requested a review from RDIL as a code owner May 8, 2025 23:57
Copy link
Member

@RDIL RDIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Separated patcher logic from UI
Bumped major version
Updated copyright notice to be consistent
@LennardF1989 LennardF1989 merged commit c63a089 into master May 9, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Patcher Product Roadmap May 9, 2025
@LennardF1989 LennardF1989 deleted the dev/patcher branch May 9, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants