Optimize UnifiedPlayerSheet performance#916
Draft
google-labs-jules[bot] wants to merge 4 commits intofix/unified-player-sheet-laggingfrom
Draft
Optimize UnifiedPlayerSheet performance#916google-labs-jules[bot] wants to merge 4 commits intofix/unified-player-sheet-laggingfrom
google-labs-jules[bot] wants to merge 4 commits intofix/unified-player-sheet-laggingfrom
Conversation
Refactored `UnifiedPlayerSheet` to reduce recompositions and eliminate jitter during expansion. - Replaced `rememberExpansionTransition` with direct `derivedStateOf` interpolation for alpha and elevation, fixing the animation jitter. - Optimized `zIndex` logic by introducing `isMiniPlayerAbove` derived boolean state, preventing recomposition on every frame. - Deferred state reads for `alpha` inside `graphicsLayer`. - Removed unused `Expansion.kt` helper file.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Refactored `UnifiedPlayerSheet` to eliminate excessive recompositions and layout thrashing during expansion/drag gestures. - Replaced `rememberExpansionTransition` with direct `derivedStateOf` interpolation for alpha and elevation, fixing the animation jitter. - Optimized `zIndex` logic by introducing `isMiniPlayerAbove` derived boolean state. - Introduced `playerLayout` custom modifier to defer height and padding updates to the layout phase, preventing recomposition of the modifier chain. - Introduced `DynamicCornerShape` to read corner radius from `State` objects during draw/layout, preventing shape instance recreation. - Wrapped all animated values (alpha, translation, padding, height) in `State` objects and updated usages to read them only inside `graphicsLayer`, `layout`, or `draw` blocks. - Deleted unused `Expansion.kt` helper file. - Fixed `MiniPlayerContentInternal` usage to avoid passing animated values.
Fixed unresolved references and ambiguity errors introduced in the previous optimization step. - Updated `queueHiddenOffsetPx` to correctly read `.value` from `currentBottomPaddingState`. - Created `Modifier.bottomPadding(State<Dp>)` using `layout` to apply bottom padding dynamically without recomposition. - Replaced usage of `.padding(bottom = ...)` with `.bottomPadding(...)`.
Optimized shape rendering to fix "stuck at 0.dp" corners and further reduce recompositions. - Replaced `DynamicCornerShape` with `dynamicRoundedShapeState` (derived state) to ensure correct shape creation. - Used `graphicsLayer` with `shape` and `clip` parameters referencing state values internally, avoiding composition invalidation. - Removed shape argument from `background` modifier, relying on the layer's clip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimized UnifiedPlayerSheet performance by refactoring state reads and removing
updateTransitionusage for continuous values. eliminated Excessive Recompositions and Alpha Jitter.PR created automatically by Jules for task 11139090902579458025 started by @theovilardo