Sort options refactor for library pills#837
Open
udaign wants to merge 5 commits intotheovilardo:masterfrom
Open
Sort options refactor for library pills#837udaign wants to merge 5 commits intotheovilardo:masterfrom
udaign wants to merge 5 commits intotheovilardo:masterfrom
Conversation
…cending/descending order button to make sorting much more efficient while also unlocking new options.
…ked: Release Year, Songs: Release Year, Artist: Song Count, Folders: Date Modified; although the date modified for folders is dysfunctional as of now.
Owner
|
Hi! Thanks for your contribution .This is a good solution but the UI padding needs to be fixed and the LibraryActionRow composable is very delicate due to the animations in it so it needs to be modified carefully |
Author
|
Updated the padding, I don't see any problems in the animations as well. Please take a second look into all the changes though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before vs After
Problem
Redundancy
For example: Name/Title - (A-Z); (Z-A) take space of two fields
Limitations in functionality
For example: If we select "Date Added" in the above picture, you couldn't choose between latest or oldest. You had to settle for the default latest. Similarly for most other options you had to stick with the defaults.
Missing sort options
Couldn't sort artists by number of songs, among a few other, which got added.
Solution
Redundancy
Solved by having a single parameter coupled with an ascending/descending arrow for each field, thus resolving redundancy and improving the efficiency. Users can now much easily scan all the available sort options without any redundancy.
Limitations in functionality
The ascending descending arrow is coupled with all supported fields, thus giving an ability to reverse the order much quicker without having to add extra options.
Missing sort options
Added additional sort options as follows:
In addition to the library pills, a similar mechanism is transferred into playlists as well, bringing similar perks along with an additional "Release Year" sort option within a playlist.