feat: Introduce new widget styles with dynamic theming#1155
Open
adlifarizi wants to merge 4 commits intotheovilardo:masterfrom
Open
feat: Introduce new widget styles with dynamic theming#1155adlifarizi wants to merge 4 commits intotheovilardo:masterfrom
adlifarizi wants to merge 4 commits intotheovilardo:masterfrom
Conversation
Introduces three new home screen widgets for player control: - A compact 4x1 "Bar" widget. - A 4x2 "Control" widget with extended controls (shuffle, repeat). - A 2x2 "Grid" widget with a minimal, album-art-focused layout.
…olor mapping - Changed theme fields in `PlayerInfo` for more specific control over widget element colors (surface container, title, artist, and playback controls). - Enhance `MusicService` to support Android 12+ dynamic color schemes based on user preferences. - Refactor `BarWidget4x1`, `ControlWidget4x2`, and `GridWidget2x2` to use the new specific color providers for improved visual consistency.
- Extracts common widget UI elements into `WidgetComponents.kt` and `WidgetUtils.kt`, including shared logic for album art caching and dynamic color providing. - Implements dedicated XML layouts and vector drawables for high-fidelity widget previews in the system widget picker. - Updates `BarWidget4x1`, `ControlWidget4x2`, and `GridWidget2x2` to use the new shared components and color mapping. - Removes the old `PixelPlayGlanceWidgetReceiver` from the manifest.
- Updates `PreviousButton`, `NextButton`, and `PlayPauseButton` in `WidgetComponents.kt` to accept an `iconSize` parameter. - Implements dynamic sizing for icons and album art in `GridWidget2x2.kt` based on the available widget dimensions.
Owner
|
Hi! This is actually pretty impressive and very similar to what I had in mind, I don't have much time to review full code but if these widgets do not replace the original I'll be approving this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces three new glance widget styles (BarWidget4x1, ControlWidget4x2, GridWidget2x2) to improve the home screen experience. It also includes support for dynamic themes, which follow the user's
Player Themepreferences using system dynamic or album art, as well as following the pallete style album art preferences.Note
I deleted the old widget from the receiver manifest so that the old widget did not appear in the picker widget, but I did not delete all files related to the old widget if needed in the future or as a reference
Because this is related to M3E design, maybe I need your approval/feedback. Here are some screenshots for the review
Widget Picker Preview
**Widget Homescreen Preview **
*This screenshot is in system dark theme, I forgot to include light theme, but the color follow actual full player theme
