fix(wip): render analytics link (when available) in all flow settings views #5878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zz-hh-aa
commented
Dec 10, 2025
|
|
||
| const analyticsLink = | ||
| environment === "production" && dashboardId | ||
| environment === "production" && dashboardId // change to "development" for local testing (we don't have analytics in staging) |
Collaborator
Author
There was a problem hiding this comment.
To test this locally, swap environment check to development here and go to a service that is marked online
PizzaDeployed a91caa8 to https://5878.planx.pizza. Useful links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug only shows analytics links when the nav bar first loads, but when a user navigates to another tab, the link disappears.
I can achieve our desired functionality but only by creating an infinite loop! Switching to
useEffectsidesteps the circular dependency and fixes the infinite loop, but not the functionality.Any tips?