Skip to content

Conversation

@DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Dec 19, 2025

Before

  • An LDC is received (e.g. lds.listedBuildingWorks)
  • It does not have a value found in ldcDescriptionFns
  • The .join("; ") operations converts the empty array to the falsy ""
  • The fallback condition "Not provided" is reached - despite there being a valid proposal.description

After

  • An LDC is received (e.g. lds.listedBuildingWorks)
  • It does not have a value found in ldcDescriptionFns
  • Fallback to proposal.description if possible, otherwise just "Not provided"

There might well be a content solution alongside this, for example have a LDC LBW specific description field, but having this fallback in place should prevent future issues here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants