fix: Ensure fallback works for LDCs #900
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
lds.listedBuildingWorks)ldcDescriptionFns.join("; ")operations converts the empty array to the falsy"""Not provided"is reached - despite there being a validproposal.description❌After
lds.listedBuildingWorks)ldcDescriptionFnsproposal.descriptionif possible, otherwise just"Not provided"✅There might well be a content solution alongside this, for example have a LDC LBW specific description field, but having this fallback in place should prevent future issues here.