Skip to content

Conversation

@ianjon3s
Copy link
Contributor

@ianjon3s ianjon3s commented Sep 11, 2025

What does this PR do?

  • Adds styles to geocode-autocomplete web component, with CSS custom properties to allow overrides in the Local Planning Service repo
  • Removes chevron down icon - this is not required as the autocomplete options appear automatically, unlike the postcode lookup a user click isn't needed to view options (it also takes no effect)

(no image preview as I can't get it running locally)

@netlify
Copy link

netlify bot commented Sep 11, 2025

Deploy Preview for oslmap ready!

Name Link
🔨 Latest commit 27a31cc
🔍 Latest deploy log https://app.netlify.com/projects/oslmap/deploys/68c2e62770dee40008bb5b5f
😎 Deploy Preview https://deploy-preview-577--oslmap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ianjon3s ianjon3s requested a review from a team September 11, 2025 15:10
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great here!

Let's debug your local dev environment tomorrow! In the meantime, the Netlify deploy associated with this PR are the Pitsby docs which have an "Edit in playground" feature with a "Styles" tab where I think you should be able to test these?

Once merged, also happy to get a new release across so you can use in LPS ➕


@property({ type: String })
arrowStyle: ArrowStyleEnum = "default";

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification 👍

@ianjon3s
Copy link
Contributor Author

Thanks @jessicamcinchak 🙏 good to know about the Pitsby docs, I'd not looked into that before.

Looks all good for this component, I think I'm just missing an API key to view it locally, but once it's in LPS I can use custom properties to refine anything, now that they are declared on the web component.

@ianjon3s ianjon3s merged commit 1012aca into main Sep 12, 2025
5 checks passed
@ianjon3s ianjon3s deleted the ian/geocode-autocomplete-styling branch September 12, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants