-
Notifications
You must be signed in to change notification settings - Fork 41
342 achieving one to one mapping with core ifc classes #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jgunstone
merged 15 commits into
theodi:master
from
jgunstone:342-achieving-one-to-one-mapping-with-core-ifc-classes
Jul 9, 2025
Merged
342 achieving one to one mapping with core ifc classes #352
jgunstone
merged 15 commits into
theodi:master
from
jgunstone:342-achieving-one-to-one-mapping-with-core-ifc-classes
Jul 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bump itables. add allow_html. ruff format
fix some structure descriptions
…so it can be the default mapping to IfcDistributionBoard
IfcAirToAirHeatRecovery -> IfcSpaceHeater
make one-to-many mappings inc. `is_ifc_default` column = 0 AND set to IfcSomethingNOTDEFINED
pisuke
approved these changes
Jul 3, 2025
Collaborator
pisuke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Collaborator
Author
|
gonna merge so I can rebase my systems branch from the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was discussed in 03/07 weekly meeting -
there was an action to add
can_be_connectedvalues which is now done so should be ready to merge@pisuke