Handle invalid player configs #196
Conversation
…ety-issues-ztxzwa Remove unused freeze implementation
Fix broadcast filters and stabilize string helpers
…-dll-file-size Reduce release DLL size by using header-only fmt
…xitlevel-routine Harden ExitLevel intermission screenshot handling
…on-error-in-g_main.cpp Fix map list shuffle format usage
…ion-error Fix screenshot command format strings
…nment-in-spawnentities Ensure override checks see updated map name
…ion-in-spawnentities Reset num_entities after clearing entity array
…to-manage-server_flags Ensure server loading flag persists through initialization
…on-in-spawnentities
…alue-initialization-in-spawnentities Add helper to reset level struct safely
…s-for-code-reuse Refactor SpawnEntities entity parsing
…opulation-after-reset Preserve level entity string
…or-g_entities Refactor G_Find to use span
…to-use-vector-arithmetic Refactor findradius center distance calculation
…game.motd-memory Handle MOTD buffer lifecycle
…remain-for-graceful-end Handle Horde rounds when no active players remain
…nd-entries Add null check for menu status bar entries
…nt-in-p_menu_buildstatusbar Adjust status bar caret alignment
…ng-logic-for-serialization Restore writeip persistence
…-helper-and-replace-push/pop Add RAII guard for JSON stack handling
…er-fatal-error-handling Stop emitting JSON warnings after fatal errors
…th_max-to-float-before-division Fix vampiric regen cap rounding and add regression test
…ain-behavior-and-add-unit-test Handle empty horde rosters in life check
…ndlymessage-for-spectators Ensure spectators inherit team chat prefix
…in-main Reset shared state between CTF flag tests
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (buffer) { | ||
| gi.TagFree(buffer); | ||
| } |
There was a problem hiding this comment.
If fread returns short after allocating buffer, cfg_valid becomes false and the invalid-path frees buffer here, but execution now falls through and the cleanup at lines 358-359 frees the same pointer again because there is no early return and buffer is never nulled. Hitting a truncated or unreadable player config will therefore double free the TagMalloc allocation and can crash the server during connect instead of regenerating the file.
Useful? React with 👍 / 👎.
ozy24
force-pushed
the
main
branch
2 times, most recently
from
e51338e to
c2adaf5
Compare
Summary
Testing
Codex Task