Fix unwatch icon#1
Open
Damillora wants to merge 2 commits intothemachinist:masterfrom
Damillora:master
Open
Conversation
added 2 commits
August 16, 2014 13:50
Does not show on my MediaWiki 1.23.2
The more elegant workaround: class="fa fa-eye"
Owner
|
hey grox. i actually didnt add an icon to the unwatch button. there is a function in DiscourseSkin.skin.php named insertIcons(). if we add a line that looks like this: $this->addKeyToArrayIfExist( $this->data['content_navigation']['actions']['unwatch'], 'icon_class', "fa-eye" );it should add the eye icon. i will add a commit with this change. |
Owner
Author
|
I got more errors after installing the Echo extension (probably this isn't the cause) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does not show on my MediaWiki 1.23.2
Spits out error message Undefined index (icon_class) instead