PaymentController uses the "return_context" field instead of "transaction_id" #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the "transaction_id" field for retrieving the Order, the PaymentController now uses the "return_context" field, which is initialized in the payment request with the order reference.
This is a safe way to remove filtering by module ID when searching the paid order :
We have now :
$order = OrderQuery::create()->findOneByRef($result['return_context']);This way, modules extending Atos (such as AtosNx) are naturally supported the Atos PaymentController.
The PR also include minor code style fixes