Draft
Conversation
Owner
|
Just a heads up, I might be a bit busy next week, so my commits may be lighter than usual. I'll do my best to help with the modular engine design decisions and overall direction though. Thanks for understanding! |
* derive more for Size * derive more for Position * add rect
Collaborator
Author
|
Thanks for letting me know :). Will drop a comment here if there is anything that we should discuss. Feel free to check out the changes every now and then and give any feedback if you notice something. |
Owner
|
I've got a small suggestion for renaming |
Collaborator
Author
|
Sure, I think |
* remove subbuffer * use Rect instead of position size in subbuffer * fmt
* cleanup widget impls * improve timer ergonomics * export delta type alias for verbosity this also reduces the refactor needed if we change stuff around in the future * use correct type for placeholder delta
* add basic renderer * start crossterm renderer * add total for delta types * unify update logic in Timer * unused import * use renderer return value in return * finish crossterm renderer * implement draw function for crossterm renderer * move init to init :P * add optimization note * fmt * docs * unused import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The modular design of the engine is intended to be a re-implementation of the current system with modularity.
What needs to be done for feature parity (non exhaustive):