Declare cli.toml files as managed via Puppet#323
Open
quba42 wants to merge 1 commit intotheforeman:masterfrom
Open
Declare cli.toml files as managed via Puppet#323quba42 wants to merge 1 commit intotheforeman:masterfrom
quba42 wants to merge 1 commit intotheforeman:masterfrom
Conversation
ekohl
requested changes
Feb 13, 2024
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
Would it help if we exposed the manage_root_config parameter as an installer parameter?
templates/cli-config.toml.epp
Outdated
| Optional[Boolean] $verify_ssl = undef, | ||
| Optional[Boolean] $dry_run = undef, | ||
| | -%> | ||
| # This file is managed by puppet-pulpcore. Manual edits will be overwritten with the next run. |
Member
There was a problem hiding this comment.
This may not be true. There's a condition on it being managed:
puppet-pulpcore/manifests/cli.pp
Line 61 in cb95de6
So what users can do is:
- Run
foreman-installer - Set
pulpcore::manage_root_config: falsein/etc/foreman-installer/custom-hiera.yaml - Run
foreman-installer
Now you have the file /root/.config/pulp on disk with this warning, but it's no longer managed.
I don't see a good way around this.
Contributor
Author
There was a problem hiding this comment.
Hmm, is it possible to have Puppet check for just the one line and remove it if pulpcore::manage_root_config: false?
Contributor
Author
There was a problem hiding this comment.
I have amended the wording.
quba42
force-pushed
the
declare_cli_config_as_managed
branch
from
2f4fee1 to
194e89c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would have saved us some confusion (though we did suspect foreman-installer had started overwriting our config pretty quickly).
I am not attached to the precise wording or formatting.
The idea is similar to #210 but for the
cli.tomlfiles written by this module.Not a Puppet expert so please do tell me what else I need to add for this to become mergable.