-
Notifications
You must be signed in to change notification settings - Fork 21
Run pulpcore-manager check --deploy as part of the tests
#352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Django has a checks framework that can detect problems in a deployment. It's also extensible and allows Pulp and plugin developers to add their own checks. This allows detection of misconfigurations. Some checks run implicitly before running certain commands but others don't for performance reasons. `--deploy` signals that a production setup is used, which enables more checks. Ideally, we'd also run with `--fail-level WARNING`, but there are too many warnings right now to fix them all. https://docs.djangoproject.com/en/5.2/topics/checks/
|
This ports @ekohl's theforeman/puppet-pulpcore#155 over to the container world. |
ehelms
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description of this makes me think it would be useful as a post install check.
You mean one that is performed as part of |
|
In a quadlet you can define a health check. Could we leverage that? This particular check may not be suitable for it, but I'd like to leverage native systemd and podman functionality where possible. |
|
Let's continue that discussion in #353 |
|
I'm surprised this passed, but my Puppet version failed with many warnings. Any idea why? |
|
Quoting my commit message: |
|
Ah yes, now I see it. Thanks! |
Django has a checks framework that can detect problems in a deployment. It's also extensible and allows Pulp and plugin developers to add their own checks. This allows detection of misconfigurations.
Some checks run implicitly before running certain commands but others don't for performance reasons.
--deploysignals that a production setup is used, which enables more checks.Ideally, we'd also run with
--fail-level WARNING, but there are too many warnings right now to fix them all.https://docs.djangoproject.com/en/5.2/topics/checks/