refactor ext db test into normal test matrix #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
force-pushed
the
refactor-extdb-test
branch
2 times, most recently
from
132d32a to
48947e7
Compare
Member
Author
ehelms
approved these changes
Dec 3, 2025
Member
ehelms
left a comment
ehelms
left a comment
There was a problem hiding this comment.
I wish the reporting was nicer to make it clear what was run:
[Test / tests (default, none, external) (pull_request)](https://github.com/theforeman/foremanctl/actions/runs/19888492813/job/57001229184?pr=348)
Test / tests (default, none, external) (pull_request)Successful in 34m
[Test / tests (default, none, internal) (pull_request)](https://github.com/theforeman/foremanctl/actions/runs/19888492813/job/57001229129?pr=348)
Test / tests (default, none, internal) (pull_request)Successful in 29m
[Test / tests (installer, none, internal) (pull_request)](https://github.com/theforeman/foremanctl/actions/runs/19888492813/job/57001229139?pr=348)
Test / tests (installer, none, internal) (pull_request)Successful in 31m
default, none, internal -- isn't the easy to understand at a glance that it's (certificates, security, database)
evgeni
force-pushed
the
refactor-extdb-test
branch
from
48947e7 to
66819d2
Compare
evgeni
force-pushed
the
refactor-extdb-test
branch
from
66819d2 to
bdb5c64
Compare
Member
Author
|
Like this? |
Member
Author
|
I'll assume so :) |
Member
|
Much better! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.