update defaults to define 4 generic timers

[archanaserver]

Depends on theforeman/foreman#10784

• Update foreman_recurring_tasks defaults to define 4 generic
  timers:
  • hourly → cron:hourly
  • daily → cron:daily
  • weekly → cron:weekly
  • monthly → cron:monthly
• Keep ldap:refresh_usergroups as a separate recurring job with
  its existing OnCalendar expression, since it runs every 30
  minutes and does not fit cleanly into the hourly/daily/weekly
  buckets yet.

[archanaserver]

Now that Foreman core provides cron:hourly, cron:daily, cron:weekly and cron:monthly rake tasks theforeman/foreman#10784, foremanctl can use those as generic entrypoints for recurring jobs instead of wiring individual rake tasks.

[evgeni]

marked as draft, as core patch is not in yet

[archanaserver]

@evgeni now that #288 is merged, we can look for this one and theforeman/foreman#10784?

[evgeni]

@evgeni now that #288 is merged, we can look for this one and theforeman/foreman#10784?

Yes!

[evgeni]

The tests needs to be updated, and we need to wait for theforeman/foreman#10784 to be merged before this can go in.

[archanaserver]

The tests needs to be updated, and we need to wait for theforeman/foreman#10784 to be merged before this can go in.

@evgeni which tests you are taking about?

[evgeni]

foremanctl/tests/foreman_test.py

Lines 71 to 81 in fed186b

	@pytest.mark.parametrize("instance", RECURRING_INSTANCES)
	def test_foreman_recurring_timers_enabled_and_running(server, instance):
	timer = server.service(f"foreman-recurring@{instance}.timer")
	assert timer.is_enabled
	assert timer.is_running
	@pytest.mark.parametrize("instance", RECURRING_INSTANCES)
	def test_foreman_recurring_services_exist(server, instance):
	service = server.service(f"foreman-recurring@{instance}.service")
	assert service.exists

[evgeni]

Conceptually ACK, this does what it should.

Given the new cron:* rake tasks are 3.18+ only, I'll wait with merging this until we have a 3.17 release of foremanctl branched out.

[evgeni]

I've tagged a 1.1.0 as a last 3.16 release and started the 3.17 part here: #368

[ekohl]

I think it raises the question how we deal with version support. For now foremanctl has been experimental and we never gave any upgrade guarantees.

When do we start committing to that? Here it would mean to clean up the old tasks (ensuring them as absent) once the version is greater than 3.18.

At the very least this needs to update the compatibility section in README to list Foreman 3.18 as the minimum version.

[evgeni]

I think it raises the question how we deal with version support. For now foremanctl has been experimental and we never gave any upgrade guarantees.

And I'd keep it at that for now.

When do we start committing to that? Here it would mean to clean up the old tasks (ensuring them as absent) once the version is greater than 3.18.

At the very least this needs to update the compatibility section in README to list Foreman 3.18 as the minimum version.

Ack, the README will need an update, but that would happen once something like #368 happens anyway for a 3.18-based branch