-
Notifications
You must be signed in to change notification settings - Fork 21
Add support for authenticated registries #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ehelms
wants to merge
1
commit into
theforeman:master
Choose a base branch
from
ehelms:add-auth-file-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2926317 to
ed0815f
Compare
cf006d9 to
24bbeef
Compare
pablomh
reviewed
Jan 9, 2026
pablomh
reviewed
Jan 9, 2026
24bbeef to
812ded7
Compare
pablomh
reviewed
Jan 14, 2026
ed5d92d to
b90a0a2
Compare
pablomh
reviewed
Jan 16, 2026
pablomh
reviewed
Jan 16, 2026
pablomh
reviewed
Jan 16, 2026
pablomh
reviewed
Jan 16, 2026
b90a0a2 to
728ce15
Compare
Contributor
|
This has worked fine with #369, so I guess that my recommendation could be ammended if needed later. |
Signed-off-by: Eric D. Helms <ericdhelms@gmail.com>
728ce15 to
bbb6195
Compare
pablomh
reviewed
Jan 20, 2026
| flavor: katello | ||
| features: [] | ||
| enabled_features: "{{ (flavor_features + features) }}" | ||
| registry_auth_file: "/etc/foreman/registry-auth.json" |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe drop the " to keep consistency with the rest of vars files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables foremanctl to authenticate with private registries by checking for auth files before attempting image pulls. Users can run
podman login <registry> --authfile=/etc/foreman/registry-auth.jsonand foremanctl will automatically use the credentials when available.