SAT-42791 - Pass docs links through LinksController#1161
Merged
chris1984 merged 1 commit intotheforeman:foreman_3_18from Mar 3, 2026
Merged
SAT-42791 - Pass docs links through LinksController#1161chris1984 merged 1 commit intotheforeman:foreman_3_18from
chris1984 merged 1 commit intotheforeman:foreman_3_18from
Conversation
(cherry picked from commit f2d29a0)
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRoutes the Subscriptions service documentation link through Foreman’s LinksController by adding a helper for the docs URL and using it in the page description component instead of a hard-coded external URL. Sequence diagram for Subscriptions service docs link via LinksControllersequenceDiagram
actor User
participant Browser
participant PageDescription
participant ForemanApp
participant LinksController
participant DocsSite
User ->> Browser: Click Subscriptions service docs link
Browser ->> PageDescription: Render component
PageDescription ->> PageDescription: getSubscriptionServiceDocsUrl()
PageDescription ->> Browser: Render anchor href /links/manual?root_url=encoded_docs_url
User ->> Browser: Click rendered anchor
Browser ->> ForemanApp: GET /links/manual?root_url=encoded_docs_url
ForemanApp ->> LinksController: Route request
LinksController ->> LinksController: Decode root_url and build redirect
LinksController -->> Browser: 302 Redirect to docs.redhat.com/subscription_central
Browser ->> DocsSite: GET docs.redhat.com/subscription_central
DocsSite -->> Browser: 200 OK docs content
Browser -->> User: Display Subscriptions service documentation
Class diagram for ForemanInventoryHelpers and PageDescription docs linkclassDiagram
class ForemanInventoryHelpers {
+getInventoryDocsUrl() string
+getSubscriptionServiceDocsUrl() string
+getActionsHistoryUrl() string
}
class PageDescription {
<<functional_component>>
+PageDescription() ReactElement
}
ForemanInventoryHelpers <.. PageDescription : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
chris1984
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit f2d29a0)
What are the changes introduced in this pull request?
Considerations taken when implementing this change?
What are the testing steps for this pull request?
Summary by Sourcery
Route the Subscriptions service documentation link through the centralized links controller for the Foreman inventory upload UI.
New Features:
Enhancements: