This repository was archived by the owner on Nov 3, 2022. It is now read-only.
Fixes #34095 - use report importer registry#98
Open
lzap wants to merge 1 commit intotheforeman:masterfrom
Open
Fixes #34095 - use report importer registry#98lzap wants to merge 1 commit intotheforeman:masterfrom
lzap wants to merge 1 commit intotheforeman:masterfrom
Conversation
Member
|
Core PR is in and I believe that this works even without the core PR so the minimum version is not necessary 🤷 |
ezr-ondrej
approved these changes
Dec 15, 2021
ekohl
suggested changes
Aug 25, 2022
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
If the minimum Foreman version should be modified, line 50 (requires_foreman) should be modified too.
Signed-off-by: Lukas Zapletal <lzap+git@redhat.com>
lzap
force-pushed
the
use-report-importer-reg-34095
branch
from
b11429d to
ceb77ac
Compare
Member
Author
|
Modified to 3.3 if that's what you mean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See theforeman/foreman#8958
Do not merge until the core PR is merged. Minimum Foreman version is now 3.2.