Draft
Conversation
8b12b29 to
cd2a063
Compare
Collaborator
test failures looks related |
stejskalleos
requested changes
Mar 3, 2026
Collaborator
stejskalleos
left a comment
There was a problem hiding this comment.
Right now, creating a new host is failing with:
Failed to upload ISO image for instance ian-warmath.dhcp-libvirt.lan: undefined method `upload_iso' for #<Fog::Libvirt::Compute::Real:345020 @uri=#<Fog::Libvirt::Util::URI:0x0000000044ef5e40 @parsed_uri=#<URI::Generic qemu:/system>, @uri="qemu:///system"> @client=#<Libvirt::Connect:0x0000000044ef56c0>> Did you mean? upload_volume
And I get another batch of errors in the log, but I'm not sure whether they are related to this PR. I need to investigate before making connections.
| private | ||
|
|
||
| def libvirt_iso_pool_name | ||
| if respond_to?(:volumes) && volumes.present? |
Collaborator
There was a problem hiding this comment.
Nitpick: Is the respond_to?(:volumes) necessary?
The libvirt.rb heavily relies on it, so I think it's safe to assume that Libvirt responds to volumes.
Collaborator
|
So, I figured out the other (irrelevant to this PR) errors, and still I got: |
Contributor
Author
|
Mark as draft because it needs fog/fog-libvirt#188 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires:
fog/fog-libvirt#188
theforeman/foreman#10874
#181