-
Notifications
You must be signed in to change notification settings - Fork 98
Fixes #38991 - Add chained task dependencies in the UI #788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Katello PR to test with: Katello/katello#11540 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is generally what I had in mind, however the tests are red
<screenshot>
Would things fit if a task was blocking and blocked at the same time?
| { | ||
| id: task.id, | ||
| action: task.action, | ||
| humanized: task.humanized[:action], | ||
| state: task.state, | ||
| result: task.result | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't say I'm a huge fan of ad-hoc data formatting. Could we instead have a main rabl json template with this and have the other templates we already have extend it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamruzicka I moved the data modeling part to a rabl json file and included it in the rabl json here as a partial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That way the data is modeled once instead of twice. It's not exactly 'extending' as you mentioned, but lemme know if it does the trick for ya.


Adds dependency information to the Foreman Tasks UI in a new Dependencies tab. Each dependency list is a table that shows the name of the task and the status.
Relates to Dynflow/dynflow#446