Skip to content

Conversation

@ianballou
Copy link
Contributor

image

Adds dependency information to the Foreman Tasks UI in a new Dependencies tab. Each dependency list is a table that shows the name of the task and the status.

Relates to Dynflow/dynflow#446

@ianballou
Copy link
Contributor Author

Katello PR to test with: Katello/katello#11540

Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is generally what I had in mind, however the tests are red

<screenshot>

Would things fit if a task was blocking and blocked at the same time?

Comment on lines 25 to 31
{
id: task.id,
action: task.action,
humanized: task.humanized[:action],
state: task.state,
result: task.result
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say I'm a huge fan of ad-hoc data formatting. Could we instead have a main rabl json template with this and have the other templates we already have extend it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamruzicka I moved the data modeling part to a rabl json file and included it in the rabl json here as a partial.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That way the data is modeled once instead of twice. It's not exactly 'extending' as you mentioned, but lemme know if it does the trick for ya.

@ianballou
Copy link
Contributor Author

ianballou commented Jan 15, 2026

Would things fit if a task was blocking and blocked at the same time?

Here is what it looks like:

image

Here it is with a squished window:

image

At the moment, with content views, there is no way to achieve this naturally since composite content views cannot be in other composite content views. But, I could see this happening as more features start to use chaining.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants