feat(test): deprecation message for test package#484
Merged
adamruzicka merged 2 commits intotheforeman:masterfrom Oct 30, 2025
Merged
feat(test): deprecation message for test package#484adamruzicka merged 2 commits intotheforeman:masterfrom
adamruzicka merged 2 commits intotheforeman:masterfrom
Conversation
MariaAga
commented
May 16, 2025
packages/test/bin/tfm-test.js
Outdated
| runScript(getJestBin(), errorHandling, jestArgs); | ||
|
|
||
| throw new Error( | ||
| '@theforeman/test package has been deprecated and will not be maintained. If you wish to continue using this packages use v15 or lower. For more information and alternatives, please refer to: https://SOME_URL.' |
Member
Author
There was a problem hiding this comment.
BREAKING CHANGE: Breaks test with an error explaining what to do
ShimShtein
approved these changes
Jun 11, 2025
Member
ShimShtein
left a comment
ShimShtein
left a comment
There was a problem hiding this comment.
Since the new testing is merged in core, we can deprecate the old testing procedure.
Don't forget to create a new version of the package!
Member
|
Now that I see all the failures, I think we should change the workflows too |
MariaAga
force-pushed
the
depreacte-test
branch
5 times, most recently
from
11b2c5c to
2c108b4
Compare
BREAKING CHANGE: Uses foremans new test logic
Member
Author
|
@ShimShtein all green 🍏 |
Contributor
|
Thank you @MariaAga ! |
|
🎉 This PR is included in version The release is available on:
Thank you for your contribution, your foreman-js bot 🤖 |
1 similar comment
|
🎉 This PR is included in version The release is available on:
Thank you for your contribution, your foreman-js bot 🤖 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Breaks test with an error explaining what to do
Merged after: theforeman/foreman#10239