Merged
Conversation
Contributor
|
Ok, you can go ahead and don't worry about me, I'll try to save your changes when I move the files to the static lib. |
Member
Author
|
Alright! Great :) Have fun at the party! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did some "drive-by" cleanup of the register view @dartfnm to reduce a bunch of code-duplication. After doing this I came to think that you mentioned that you done some refactoring on your side already. I don't want us to end up somewhere we the codebases doesn't match anymore, so would you be fine bringing in various changes to your side or would it be better for me to wait with some of the refactoring? I have some more features I want to add.