fix: updated shims and recordings for S7 support.#62
Open
seanthimons wants to merge 6 commits intothebioengineer:mainfrom
Open
fix: updated shims and recordings for S7 support.#62seanthimons wants to merge 6 commits intothebioengineer:mainfrom
seanthimons wants to merge 6 commits intothebioengineer:mainfrom
Conversation
Owner
|
Thanks for the contribution, @seanthimons! This has been on my list of things to look into, but admittedly not had the bandwidth to do so and learn a bit more about s7. I'll look into this PR post-haste and may make some house-keeping updates (bump version, updates news, etc) |
thebioengineer
requested changes
Dec 3, 2025
Co-authored-by: Ellis Hughes <ellishughes@live.com>
Co-authored-by: Ellis Hughes <ellishughes@live.com>
Co-authored-by: Ellis Hughes <ellishughes@live.com>
Co-authored-by: Ellis Hughes <ellishughes@live.com>
Co-authored-by: Ellis Hughes <ellishughes@live.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch to fix issue #60, adds S7 support.
Also updates DESCRIPTION and tests; not sure why tests were failing on the comparison - outputs were identical?
Would recommend that if this patch is not to be integrated that the version dependency for ggplot2 be pinned to the last known version rather than leaving it open.