Fixes for fixed choice list and css class combining#40
Open
crawley wants to merge 2 commits intotheatlantic:mainfrom
Open
Fixes for fixed choice list and css class combining#40crawley wants to merge 2 commits intotheatlantic:mainfrom
crawley wants to merge 2 commits intotheatlantic:mainfrom
Conversation
... in 'data' after the first call to render. This causes the widget to stop working when the user refreshes the page (for example).
... in the Select widget. This caused the css classes for the <select> element to be incorrect if you attempted to include your own classes via the widget 'attrs' hash.
Author
|
Could someone please review and merge this? I'm sure these fixes would be useful to some people. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes some bugs that I found when trying to implement select2 autocomplete with fixed choices.