Skip to content

Conversation

@flungo
Copy link

@flungo flungo commented Apr 5, 2015

I have made these changes for my benefit but am sending a PR incase you feel these changes would be advantageous for others. None of the code has been modified, just the project structure - however I would recommend that you test before accepting (I haven't had a chance to check yet, but will make any required fixes).

Advantages:

  • IDE independence (works in most major IDE without the need for any changes to the project)
  • Cross platform build system (same command to build whatever the system)
  • Simple build process mvn build and done
  • Dependency resolution done by client automatically
  • First step towards the maven ecosystem

@flungo
Copy link
Author

flungo commented Apr 5, 2015

Now tested with starter bot vs. starter bot, nothing written to err.txt.

out.txt:

setting up game
Starting game...
stopping...
winner: draw
Saving the game...
Done.

Is that correct? Can you not actually analyse or see the game output in terms of what the bots do? Only have the starter bot for now to test with and got the same with your repository and following your instructions, but somehow feel like there should be more? Like a list of the moves played by each player?

@JimVanEeden
Copy link
Contributor

I'll have a look at your changes this week. The output is correct, but if you want to see what the bots do, modify the Process method in IOPlayer class.

@flungo
Copy link
Author

flungo commented Apr 7, 2015

Yes, I worked it out. What I might do is put some event hooks in then
anyone can use this like an API to make any front end that they like. I am
all about modularity - will probably separate the engine to a separate
module so it can be shared between the game specific engines.

Would you be interested in hosting a Maven repo for theaigames.com? I can
help with setting that up if you would like, otherwise i will set a repo
for my forks so that the dependencies can be automatically resolved between
machines over the internet.
On 7 Apr 2015 09:01, "JimVanEeden" notifications@github.com wrote:

I'll have a look at your changes this week. The output is correct, but if
you want to see what the bots do, modify the Process method in IOPlayer
class.


Reply to this email directly or view it on GitHub
#1 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants