Open
Conversation
Owner
|
There was no specific thought behind the reset button, seems reasonable to want to have it clear the saved power curve for convenience. I'd prefer it as a config option that defaults to false, so I'll probably implement it slightly differently. Good to see positive interest in the tool. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that pressing the reset button does not reset the power curve, only the gear ratios. While the
EngineCurveclass is reset, it will immediately reload the saved curve from file. This pull request deletes the file on reset. Feel free to implement it differently, I just threw this PR together as a proof of concept and verified it works.Thanks for creating this tool, it works great!