Open
Conversation
Author
|
How a highlighter should work? |
Member
|
The code changes look pretty good, but I won't have a chance to test it for a day or two. Not sure what you're asking about the highlighter, but it exists to actually search for and mark the light blocks around a player. |
Author
|
I just didn't notice the marker working. I'll think about how and what can be changed for the better in a few days. |
Author
|
I think it's better to rewrite the highlighter implementation, because it's kind of weird now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed all public static that could cause memory leak
Using BukkyTask#runTimerAsync instead of BukkyTask#runTimer
Improved code structure