Open
Conversation
Collaborator
|
Have you tested this? I think this can lead to an exception because of calling |
Author
|
Yes i tested my use case (i did not run the included tests). It required an change in the builder too. See: However by writing a raw select i can use the Clickhouse JSONCompact format without modifications to ClickhouseClient and/or Builder |
Author
|
Sorry, even writing a raw select like this json_decode on request result works without issues. JSONCompact is still valid json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using a format on the builder gave an error.
The sql send to clickhpuse server contained 2 FORMAT settings.